libtool: upgrade to 1.5.26, add patch to avoid -flat_namespace

[ricci@…]

libtool 1.5.26 plus the attached patch will properly avoid the use of -flat_namespace when 'MACOSX_DEPLOYMENT_TARGET' is not set. The use of flat_namespace on 10.5.2 appears to be harmful (lots of linking problems)

[ricci@…]

Portfile patch to bring to 1.5.26

[ricci@…]

patchfile for libtool 1.5.26

[ryandesign@…]

Upgrading libtool to 1.5.26 is also supposed to fix #13182 on Leopard so I think I'll apply these patches.

[ryandesign@…]

1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set. The use of flat_namespace on 10.5.2 appears to be harmful". MacPorts always sets MACOSX_DEPLOYMENT_TARGET, so how will avoiding -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with -flat_namespace.

[ricci@…]

Replying to ryandesign@macports.org:

1.5.26 builds fine for me on 10.4 with your patch. I can't test on 10.5 right now. I also don't understand your patch, or your comment "avoid the use of -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set. The use of flat_namespace on 10.5.2 appears to be harmful". MacPorts always sets MACOSX_DEPLOYMENT_TARGET, so how will avoiding -flat_namespace when MACOSX_DEPLOYMENT_TARGET is not set help anything on Leopard? And is that really all the patch does? It looks to me like it removes a bunch of code from libtool, not all of which deals with -flat_namespace.

I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released. The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly.

[ryandesign@…]

Replying to ricci@macports.org:

I believe that always setting MACOSX_DEPLOYMENT_TARGET is not yet released.

Oh yes, you're right, that's not in MacPorts 1.6.0; that's only in trunk. I keep forgetting that.

The patch does remove a chunk of code which is bogus (libtool maintainer indicated so) and, IIRC, overrides earlier code that works properly.

Thanks. If the libtool maintainer says so, that's good enough for me. I committed it in r35661.