ImageMagick: add +rsvg variant

[bulk@…]

Hi there,

I'd love to see a "+rsvg" variant for image magick. All it needs to do is add a dependency on 'librsvg' and ImageMagick does the rest (no additional commands/configure flags needed.. it auto detects it).

thanks,

--nickg

[ryandesign@…]

I'll assign this to me, since I'm the ImageMagick maintainer. Not saying I'll resolve it immediately though.

Additional configure arguments are needed. Auto-detecting other packages is not appropriate for software installed using MacPorts. It would mean that two users would "magically" get two different versions of ImageMagick, simply if one user already had librsvg installed and the other did not. We don't want that. We want everyone who builds a port with a given set of variants to get the same software (modulo major OS versions and processor architectures). If ImageMagick auto-detects librsvg if installed, we need to add configure arguments to disable librsvg explicitly unless this new +rsvg variant is chosen.

[bulk@…]

My point was it works just like all the other libraries in ImageMagick. assuming wikitext doesn't mangle the text, it's something like the following:

Add to configure.args:

  --without-rsvg

Since right now, it WILL use rsvg if you install librsvg first

add somewhere:

variant rsvg description {Include librsvg library support} {
    depends_lib-append  port:librsvg
    configure.args-delete    --without-rsvg
    configure.args-append   --with-rsvg
}

I hope this helps,

thanks,

-nickg

[ryandesign@…]

Has duplicate #15036 which has a patch which looks a lot like what bulk@modp wrote above.

[ryandesign@…]

Committed the patch from #15036 in r36122. Thanks everyone.