Projects
New Ticket     Wiki     Browse Source     Timeline     Roadmap     Bug Reports     Search

Ticket #12314 (assigned enhancement)

Opened 17 months ago

Last modified 6 months ago

RFE: ruby-1.8.6 - patch adds a working universal variant

Reported by: eloy.de.enige@… Owned by: imajes@…
Priority: Low Milestone: Port Enhancements
Component: ports Version:
Keywords: ruby port universal Cc: eloy.de.enige@…, pguyot@…, ryandesign@…
Port:

Description

This patch adds an extra patchfile which patches ruby 1.8.6 so that it will build universal and patch mkmf.rb so that it will correctly build C extensions that use extconf. The patch also fixes an endian problem when compiling on an intel mac.

The patches are inspired by apple's patches to ruby-1.8.2 but updated for 1.8.6

All tests pass on i386 and ppc.

Attachments

ruby_universal.diff (3.3 KB) - added by eloy.de.enige@… 17 months ago.
ruby_universal_without_autoconf_dependency.diff (9.9 KB) - added by eloy.de.enige@… 16 months ago.

Change History

Changed 17 months ago by eloy.de.enige@…

Changed 16 months ago by ryandesign@…

  • cc eloy.de.enige@…, ryandesign@… added
  • milestone set to Port Enhancements

Interesting. Do any of these changes need to be submitted for inclusion upstream?

Changed 16 months ago by eloy.de.enige@…

Sorry to ask a possible dumb question, but what do you mean by "inclusion upstream"?

Changed 16 months ago by ryandesign@…

I mean: should any of these patches be delivered to the Ruby developers for inclusion directly in Ruby? There are people using Ruby on Macs who are not using MacPorts. Wouldn't they benefit from this too?

I was also curious to know where you found Apple's patches to ruby-1.8.2.

Changed 16 months ago by eloy.de.enige@…

Ah yes, I was thinking about this too indeed. I will have a look at this tomorrow to double check if there's anything that might break a regular ruby installation for non mac users.

Yes the Apple patches are invaluable :) at some point I figured Apple had to put these patches online somewhere... They're available at: http://www.opensource.apple.com/darwinsource/10.4.9.x86/ruby-22.0.1/

Changed 16 months ago by eloy.de.enige@…

Changed 16 months ago by eloy.de.enige@…

Added a new patch which removes the dependency on autoconf and thus on perl (which isn't universal atm), so it should now be possible to have a fresh macports installation and only issue: $port install ruby +universal And all dependencies should be build universal and without the bloat of perl.

Please check if the new patch-configure patch contains anything that it shouldn't contain, because I'm by no means a configure genius.

Changed 16 months ago by nox@…

  • priority changed from Nice to have to Low
  • version 1.5.0 deleted

Changed 6 months ago by imajes@…

  • owner changed from pguyot@… to imajes@…
  • status changed from new to assigned

will take this onboard for inclusion...

Note: See TracTickets for help on using tickets.