Changeset 23620

Timestamp:

05/05/08 13:23:42 (7 months ago)

Author:

zarzycki@…

Message:

<rdar://problem/5804075> launchd fork/exec log message is incorrect

Files:

• trunk/launchd/src/launchd_core_logic.c (modified) (4 diffs)

trunk/launchd/src/launchd_core_logic.c

@@ -476 +476 @@
 static void job_callback_read(job_t j, int ident);
 static void job_log_stray_pg(job_t j);
-static void job_log_chidren_without_exec(job_t j);
+static void job_log_children_without_exec(job_t j);
 static job_t job_new_anonymous(jobmgr_t jm, pid_t anonpid) __attribute__((malloc, nonnull, warn_unused_result));
 static job_t job_new(jobmgr_t jm, const char *label, const char *prog, const char *const *argv) __attribute__((malloc, nonnull(1,2), warn_unused_result));
@@ -2565 +2565 @@
 
 void
-job_log_chidren_without_exec(job_t j)
+job_log_children_without_exec(job_t j)
 {
         /* <rdar://problem/5701343> ER: Add a KERN_PROC_PPID sysctl */
@@ -2600 +2600 @@
                 }
 
-                job_log(j, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn(). Child PID %u",
+                job_log(j, LOG_APPLEONLY, "Called *fork(). Please switch to posix_spawn*(), pthreads or launchd. Child PID %u",
                                 kp[i].kp_proc.p_pid);
         }
@@ -2642 +2642 @@
         if (fflags & NOTE_FORK) {
                 job_log(j, LOG_DEBUG, "fork()ed%s", program_changed ? ". For this message only: We don't know whether this event happened before or after execve()." : "");
-                job_log_chidren_without_exec(j);
+                job_log_children_without_exec(j);
         }