Changeset 23476

Timestamp:

12/21/07 13:53:37 (12 months ago)

Author:

zarzycki@…

Message:

<rdar://problem/5317778> Bug: launchd_core_logic.c:5810 (23281):0: mspolicy_new(target_j, target_service, flags & BOOTSTRAP_ALLOW_LOOKUP, flags & BOOTSTRAP_PER_PID_SERVICE, false)

Files:

• trunk/launchd/src/launchd_core_logic.c (modified) (2 diffs)

trunk/launchd/src/launchd_core_logic.c

@@ -6523 +6523 @@
                 job_log(j, LOG_DEBUG, "Setting policy on job \"%s\" for Mach service: %s", target_j->label, target_service);
                 if (target_service[0]) {
-                        job_assumes(j, mspolicy_new(target_j, target_service, flags & BOOTSTRAP_ALLOW_LOOKUP, flags & BOOTSTRAP_PER_PID_SERVICE, false));
+                        bool r = mspolicy_new(target_j, target_service, flags & BOOTSTRAP_ALLOW_LOOKUP, flags & BOOTSTRAP_PER_PID_SERVICE, false);
+
+                        if (unlikely(!r) && job_assumes(j, errno == EEXIST)) {
+                                job_log(j, LOG_ERR, "Tried to update a known policy on PID %u: %s", target_pid, target_service);
+                        }
                 } else {
                         target_j->deny_unknown_mslookups = !(flags & BOOTSTRAP_ALLOW_LOOKUP);
@@ -6669 +6673 @@
                         continue;
                 } else if (strcmp(msp->name, name) == 0) {
+                        errno = EEXIST;
                         return false;
                 }