Changeset 23273

Timestamp:

06/06/07 09:04:51 (18 months ago)

Author:

zarzycki@…

Message:

<rdar://problem/5253449> launchctl:do_sysversion_sysctl() does not have any safety checks

Files:

• trunk/launchd/src/launchctl.c (modified) (1 diff)

trunk/launchd/src/launchctl.c

@@ -2888 +2888 @@
         }
 
-        versdict = _CFCopySystemVersionDictionary();
-        buildvers = CFDictionaryGetValue(versdict, _kCFSystemVersionBuildVersionKey);
-        CFStringGetCString(buildvers, buf, sizeof(buf), kCFStringEncodingUTF8);
-
-        if (sysctl(mib, 2, NULL, 0, buf, strlen(buf) + 1) == -1) {
-                fprintf(stderr, "sysctl(): %s\n", strerror(errno));
+        if (!assumes((versdict = _CFCopySystemVersionDictionary()))) {
+                return;
+        }
+
+        if (assumes((buildvers = CFDictionaryGetValue(versdict, _kCFSystemVersionBuildVersionKey)))) {
+                CFStringGetCString(buildvers, buf, sizeof(buf), kCFStringEncodingUTF8);
+
+                assumes(sysctl(mib, 2, NULL, 0, buf, strlen(buf) + 1) != -1);
         }